I don’t think picking one over the other has an admissions advantage. Since the on-campus interview will be most likely with a senior, your son can pick up more intel as to what is going on at Yale now. An alumni interviewer will be in a better position to tell your son how Yale has influenced him/her over a longer period of time. If it were me, I’d go with the alumni interview just for the convenience.