Yes, if your roof is nearing replacement, do that before putting solar on it.
Agree, it can be advantageous financially to install solar, but you should do your own investigation on how well it will work for you based on your electricity use and rates, what your regulatory and tax environment is, and how much sunlight you get (high latitudes are less favorable) rather than buy from a door to door salesman.