The answer from my friend is NO, Honors program students do not have 4 years guaranteed housing.
Her daughter is a National Merit Finalist, and we think that gives her 4 years guaranteed.
UCF uses a lottery system for dorms. There are the obvious priorities for students with disabilities, etc, and also apparently for National Merit scholars.
Other than that, entering freshmen have first priority and everyone else goes through a lottery. Rising sophomores who want to remain in the dorms have secondary priority within the lottery and there is also a priority given for Florida Prepaid Housing plan students.
There is a complete description of all this on the Housing page.