It’s clear the “huge public flagship with LOTS of choices” vs. “elite NYC” experiences are going to be different. Which one do you want?
It’s common to apply for a transfer to have an “out” “just in case”, and then, when offered the possibility, to realize you don’t want to go elsewhere. So, did you find you actually wanted to stay at ASU or are you still looking for something else?
Your real “pros” for NYU are personal growth and NYC opportunities. There’s no reason you wouldn’t be able to succeed or that your college experience would “be in shambles” since you’d be living in the dorms with other students.
Your real “cons” are worrying about homesickness and cost. The CS Dept doesn’t have to be “twice better” (how would you estimate that) BUT the courses&professors need to offer something different from what you have at ASU in addition to the differences in culture and setting. That difference needs to be meaningful to you and make it “worth it”. Your cons sound like made-up fears, so are you scared/excited or scared/freaked out?
Staying at ASU means you’re comfortable and aren’t paying much. If you’re tired of being in AZ, you can study abroad as much as you wish since it won’t break the bank - you can go on Barrett-only Spring or Summer programs, join EPICS, spend a semester at National University Singapore (lots of CS courses) and have an internship there; or you can ask “ASU in DC” if you could get a CS internship in DC. Things are good for you at ASU so either you want the different culture and experience you’d get at NYU and in NYC.. or you’re good where you are.