I know a number of lawyers who have had felony convictions and are practicing. Each state, each jurisdiction in each state has their own discretion within the laws regarding this. Some states are far more draconian than others.
Anyone with any criminal record should research what needs to be done to become a practicing attorney before embarking on the expense and time of the process. Actually anyone planning to become an attorney should do an early background check on themselves to make sure any impediments to being admitted to the bar are addressed. I know too many who find out at the last minute and have to scurry to get their records clear from very minor issues.
Also, there is a glut of attorneys in this country. Not easy to find jobs that can make a large loan burden and the years of study worthwhile. However , I know a number of lawyers who went to local unknown law schools who are practicing and doing well. Getting into a white shoe law firm or getting certain clerkships are mostly out of reach with such degrees, but it’s possible to get work local to any law school connections and class rank and luck come into play. The odds are not high , however, in fact , low.
So do your research before investing too much into something like this.