Should my rising senior take Physics when the teacher is not great?

Yes but doesn’t mean it needs to be physics. Mine had no physics - got into a top LAC (W&L) and semi top publics (UF, UMD, etc.)

Would it be good prep - yes - but is it required - unlikely.